Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap the order of the sdist and wheel checks #866

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Swap the order of the sdist and wheel checks #866

merged 1 commit into from
Jul 18, 2024

Conversation

mikealfare
Copy link
Contributor

Problem

We're seeing the results of incompatible versions of setuptools and packaging when testing artifacts. They show up when checking the wheel first. It appears that installing the wheel updates the virtual environment in a way that is incompatible with the sdist.

Solution

Swap the order of the checks and check the sdist first.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare added the Skip Changelog Skips GHA to check for changelog file label Jul 18, 2024
@mikealfare mikealfare self-assigned this Jul 18, 2024
@cla-bot cla-bot bot added the cla:yes label Jul 18, 2024
@mikealfare mikealfare merged commit fde4a55 into 1.3.latest Jul 18, 2024
36 checks passed
@mikealfare mikealfare deleted the fix-setuptools-packaging-issue branch July 18, 2024 19:57
mikealfare added a commit that referenced this pull request Jul 18, 2024
@mikealfare
swap the order of the sdist and wheel checks (#866)
589b643
@mikealfare mikealfare mentioned this pull request Jul 18, 2024
Merged
mikealfare added a commit that referenced this pull request Jul 18, 2024
@mikealfare
swap the order of the sdist and wheel checks (#866)
b3521f8
@mikealfare mikealfare mentioned this pull request Jul 18, 2024
Merged
mikealfare added a commit that referenced this pull request Jul 18, 2024
@mikealfare
swap the order of the sdist and wheel checks (#866)
7584bc9
@mikealfare mikealfare mentioned this pull request Jul 18, 2024
Merged
mikealfare added a commit that referenced this pull request Jul 18, 2024
@mikealfare
swap the order of the sdist and wheel checks (#866) (#871)
a7b5fc8
mikealfare added a commit that referenced this pull request Jul 18, 2024
@mikealfare
swap the order of the sdist and wheel checks (#866) (#872)
1ffe0a4
mikealfare added a commit that referenced this pull request Jul 18, 2024
@mikealfare
swap the order of the sdist and wheel checks (#866) (#873)
91292c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichelleArk MichelleArk MichelleArk approved these changes

Assignees

@mikealfare mikealfare

Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikealfare @MichelleArk